Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decompress_chunk to nodes/decompress_chunk #1513

Merged
merged 1 commit into from Nov 6, 2019

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm requested a review from cevian November 1, 2019 15:40
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #1513 into master will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
+ Coverage   91.48%   91.81%   +0.33%     
==========================================
  Files         144      142       -2     
  Lines       21442    20511     -931     
==========================================
- Hits        19616    18832     -784     
+ Misses       1826     1679     -147
Flag Coverage Δ
#cron ?
#pr 91.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
tsl/src/init.c 93.75% <ø> (ø) ⬆️
tsl/src/nodes/decompress_chunk/exec.c 96.71% <ø> (ø)
tsl/src/nodes/decompress_chunk/planner.c 97.14% <ø> (ø)
tsl/src/nodes/decompress_chunk/qual_pushdown.c 90.71% <ø> (ø)
tsl/src/planner.c 100% <ø> (ø) ⬆️
tsl/src/nodes/decompress_chunk/decompress_chunk.c 92.79% <ø> (ø)
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-11.48%) ⬇️
src/cache_invalidate.c 78.12% <0%> (-2.44%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874b451...b63a053. Read the comment docs.

Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description to commit message. Otherwise LGTM

Code for all custom nodes should live under the nodes directory
to make different parts of the code easier to distinguish.
@svenklemm svenklemm merged commit c6350aa into timescale:master Nov 6, 2019
@cevian cevian added this to the 1.6.0 milestone Jan 8, 2020
@svenklemm svenklemm deleted the move_decompress_chunk branch April 18, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants