Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use function cache to check for valid bucketing functions #1549

Merged
merged 1 commit into from Nov 26, 2019

Conversation

svenklemm
Copy link
Member

Refactor the continuous aggregate validation to use our function cache
to check for bucketing function. This simplifies the code and allows
adding support for other bucketing functions like date_trunc later on.

@svenklemm svenklemm force-pushed the cagg_bucket branch 2 times, most recently from 8e1c523 to e57abf1 Compare November 26, 2019 12:14
Refactor the continuous aggregate validation to use our function cache
to check for bucketing function. This simplifies the code and allows
adding support for other bucketing functions like date_trunc later on.
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #1549 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
+ Coverage   91.48%   91.79%   +0.31%     
==========================================
  Files         144      142       -2     
  Lines       21450    20495     -955     
==========================================
- Hits        19624    18814     -810     
+ Misses       1826     1681     -145
Flag Coverage Δ
#cron ?
#pr 91.79% <100%> (-0.02%) ⬇️
Impacted Files Coverage Δ
tsl/src/continuous_aggs/create.c 97.5% <100%> (+0.02%) ⬆️
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-11.48%) ⬇️
src/cache_invalidate.c 78.12% <0%> (-2.44%) ⬇️
src/loader/bgw_launcher.c 89.36% <0%> (-2.25%) ⬇️
src/bgw_policy/chunk_stats.c 83.92% <0%> (-1.56%) ⬇️
src/loader/loader.c 91.57% <0%> (-1.25%) ⬇️
src/histogram.c 89.02% <0%> (-1.22%) ⬇️
src/estimate.c 86.17% <0%> (-0.83%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5d0d4...30b4080. Read the comment docs.

@svenklemm svenklemm merged commit e82b94a into timescale:master Nov 26, 2019
@cevian cevian added this to the 1.6.0 milestone Dec 4, 2019
@svenklemm svenklemm deleted the cagg_bucket branch April 18, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants