Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Wdeclaration-after-statement from PG_CFLAGS #1637

Merged
merged 1 commit into from Jan 17, 2020

Conversation

svenklemm
Copy link
Member

Postgres CFLAGS includes -Wdeclaration-after-statement which leads
to problems when compiling with -Werror since we aim for C99 and allow
that so we strip this flag from PG_CFLAGS before adding postgres flags
to our own

@svenklemm svenklemm requested a review from a team January 17, 2020 09:26
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I think you can remove the space before the flag.

src/build-defs.cmake Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1637 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
+ Coverage   91.54%   91.89%   +0.34%     
==========================================
  Files         144      142       -2     
  Lines       21959    21014     -945     
==========================================
- Hits        20102    19310     -792     
+ Misses       1857     1704     -153
Flag Coverage Δ
#cron ?
#pr 91.89% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-10.95%) ⬇️
src/cache_invalidate.c 78.12% <0%> (-2.44%) ⬇️
src/bgw_policy/chunk_stats.c 83.92% <0%> (-1.56%) ⬇️
src/loader/loader.c 91.57% <0%> (-1.25%) ⬇️
src/histogram.c 89.02% <0%> (-1.22%) ⬇️
src/estimate.c 86.17% <0%> (-0.83%) ⬇️
src/telemetry/telemetry.c 79.55% <0%> (-0.71%) ⬇️
src/cache.c 84.82% <0%> (-0.65%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38654b2...f77c166. Read the comment docs.

Postgres CFLAGS includes -Wdeclaration-after-statement which leads
to problems when compiling with -Werror since we aim for C99 and allow
that so we strip this flag from PG_CFLAGS before adding postgres flags
to our own
@svenklemm svenklemm merged commit bae0838 into timescale:master Jan 17, 2020
@svenklemm svenklemm deleted the declaration-after-statement branch April 18, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants