Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move enterprise features to community #1672

Merged

Conversation

erimatnor
Copy link
Contributor

@erimatnor erimatnor commented Feb 4, 2020

As of this change, a number of enterprise features are accessible to
community users. These features include:

  • reorder
  • policies around reorder and drop chunks

The move chunks feature is still covered by enterprise. Gapfill no
longer warns about expired enterprise license.

Tests have been updated to reflect these changes.

@erimatnor erimatnor added this to the 1.7.0 milestone Feb 4, 2020
@erimatnor erimatnor requested a review from a team as a code owner February 4, 2020 08:33
@erimatnor erimatnor requested review from pmwkaa, mkindahl and k-rus and removed request for a team February 4, 2020 08:33
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch 2 times, most recently from 737e85c to 59a0a96 Compare February 4, 2020 09:59
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tsl/src/bgw_policy/drop_chunks_api.c Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch from 59a0a96 to 8df2ad0 Compare February 4, 2020 10:50
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #1672 into master will increase coverage by 0.28%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
+ Coverage   91.59%   91.88%   +0.28%     
==========================================
  Files         144      142       -2     
  Lines       21921    20929     -992     
==========================================
- Hits        20079    19230     -849     
+ Misses       1842     1699     -143
Flag Coverage Δ
#cron ?
#pr 91.88% <80%> (-0.05%) ⬇️
Impacted Files Coverage Δ
src/cross_module_fn.c 68.54% <ø> (ø) ⬆️
tsl/src/reorder.c 81.08% <ø> (+0.48%) ⬆️
tsl/src/bgw_policy/drop_chunks_api.c 98.07% <ø> (-0.14%) ⬇️
tsl/src/nodes/gapfill/gapfill.c 100% <ø> (ø) ⬆️
tsl/src/bgw_policy/reorder_api.c 98.3% <ø> (-0.11%) ⬇️
tsl/src/nodes/gapfill/planner.c 96.8% <ø> (-0.02%) ⬇️
tsl/src/bgw_policy/job.c 89.57% <80%> (-0.21%) ⬇️
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-10.95%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f47c0...fbccbc5. Read the comment docs.

tsl/test/sql/tsl_tables.sql Outdated Show resolved Hide resolved
tsl/test/sql/tsl_tables.sql Outdated Show resolved Hide resolved
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch 3 times, most recently from a22e5de to 4f42819 Compare February 7, 2020 09:02
Copy link
Contributor

@pmwkaa pmwkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch from 4f42819 to 4acba83 Compare February 13, 2020 10:33
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch from 4acba83 to 85ba19d Compare February 14, 2020 08:52
CHANGELOG.md Outdated Show resolved Hide resolved
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch 2 times, most recently from 9432810 to 6a0c476 Compare February 17, 2020 09:41
CHANGELOG.md Outdated Show resolved Hide resolved
As of this change, a number of enterprise features are accessible to
community users. These features include:

* reorder
* policies around reorder and drop chunks

The move chunks feature is still covered by enterprise. Gapfill no
longer warns about expired enterprise license.

Tests have been updated to reflect these changes.
@erimatnor erimatnor force-pushed the enterprise-to-community-license-change branch from 6a0c476 to fbccbc5 Compare February 20, 2020 13:49
@erimatnor erimatnor merged commit 9da50cc into timescale:master Feb 20, 2020
@jflambert
Copy link

Is it possible that the docs still need to be updated? I don't see "Community Edition" badges next to most of the automation policies functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants