Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cascade_to_materialization #2163

Merged
merged 1 commit into from Jul 31, 2020
Merged

Remove cascade_to_materialization #2163

merged 1 commit into from Jul 31, 2020

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Jul 30, 2020 •
edited

The parameter cascade_to_materialization is removed from
drop_chunks and add_drop_chunks_policy as well as associated tables
and test functions.

Fixes #2137

@mkindahl mkindahl self-assigned this Jul 30, 2020
@mkindahl mkindahl force-pushed the remove_cascade_to_materialization branch 2 times, most recently from ceb93fb to 238b75a Compare July 30, 2020 13:12
@mkindahl mkindahl marked this pull request as ready for review July 30, 2020 13:56
@mkindahl mkindahl requested a review from a team as a code owner July 30, 2020 13:56
@mkindahl mkindahl requested review from pmwkaa, erimatnor and gayyappan and removed request for a team July 30, 2020 13:56
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

Merging #2163 into master will increase coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   89.93%   89.99%   +0.06%     
==========================================
  Files         210      210              
  Lines       34202    34127      -75     
==========================================
- Hits        30759    30714      -45     
+ Misses       3443     3413      -30
Impacted Files Coverage Δ
src/bgw_policy/drop_chunks.c 98.18% <ø> (+2.86%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.h 100.00% <ø> (ø)
tsl/src/bgw_policy/job.c 81.74% <ø> (ø)
tsl/src/chunk.c 58.94% <0.00%> (+0.61%) ⬆️
tsl/src/continuous_aggs/drop.c 0.00% <ø> (-88.89%) ⬇️
src/chunk.c 95.30% <100.00%> (-0.05%) ⬇️
tsl/src/bgw_policy/drop_chunks_api.c 97.82% <100.00%> (-0.10%) ⬇️
tsl/test/src/deparse.c 95.12% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93f963...6d2cb82. Read the comment docs.

svenklemm
svenklemm approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to drop column and function in latest-dev, function might already be their though from other changes

@mkindahl
Copy link
Contributor Author

need to drop column and function in latest-dev, function might already be their though from other changes

Right. Will check.

@mkindahl
Copy link
Contributor Author

mkindahl commented Jul 30, 2020 •
edited

need to drop column and function in latest-dev, function might already be their though from other changes

Hmm.... I am recreating the table, so that should solve the issue with the table. I can drop the function though. The function is already dropped quite early in latest-dev.sql.

@mkindahl mkindahl force-pushed the remove_cascade_to_materialization branch 2 times, most recently from 78e5fcf to dbee419 Compare July 30, 2020 19:22
@svenklemm
Copy link
Member

yes doesnt matter anyway as i'm gonna drop it

WireBaron
WireBaron approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I assume you're also updating the docs?

@mkindahl
Copy link
Contributor Author

This looks good, I assume you're also updating the docs?

Yes, I will create a PR for the docs.

@mkindahl
Remove cascade_to_materialization parameter
6d2cb82 
The parameter `cascade_to_materialization` is removed from
`drop_chunks` and `add_drop_chunks_policy` as well as associated tables
and test functions.

Fixes timescale#2137
@mkindahl mkindahl force-pushed the remove_cascade_to_materialization branch from dbee419 to 6d2cb82 Compare July 30, 2020 20:41
@mkindahl mkindahl merged commit 590446c into timescale:master Jul 31, 2020
@mkindahl mkindahl deleted the remove_cascade_to_materialization branch July 31, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WireBaron WireBaron WireBaron approved these changes

@svenklemm svenklemm svenklemm approved these changes

@pmwkaa pmwkaa Awaiting requested review from pmwkaa

@erimatnor erimatnor Awaiting requested review from erimatnor

@gayyappan gayyappan Awaiting requested review from gayyappan

Assignees

@mkindahl mkindahl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove cascade_to_materialization from drop_chunks
3 participants
@mkindahl @svenklemm @WireBaron