Rename continuous aggregate policy API (+restructure) #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
rename-cagg-policy
branch
2 times, most recently
from
3ca204f
to
08df8ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #2368 +/- ##
==========================================
- Coverage 90.38% 90.33% -0.05%
==========================================
Files 213 213
Lines 34825 34900 +75
==========================================
+ Hits 31476 31528 +52
- Misses 3349 3372 +23
Continue to review full report at Codecov.
|
svenklemm
approved these changes
Sep 11, 2020
pmwkaa
approved these changes
Sep 11, 2020
I agree, this mostly applies to SQL code though and we've talked about enforcing a standard formatter. Let's do that. In the meantime, I'll try to clean things up for this commit. |
erimatnor
force-pushed
the
rename-cagg-policy
branch
from
08df8ae
to
05b0cef
Compare
This change simplifies the name of the functions for adding and removing a continuous aggregate policy. The functions are renamed from: - `add_refresh_continuous_aggregate_policy` - `remove_refresh_continuous_aggregate_policy` to - `add_continuous_aggregate_policy` - `remove_continuous_aggregate_policy` Fixes timescale#2320
This moves the SQL definitions for policy and job APIs to their separate files to improve code structure. Previously, all of these user-visible API functions were located in the `bgw_scheduler.sql` file, mixing internal and public functions and APIs. To improved the structure, all API-related functions are now located in their own distinct SQL files that have the `_api.sql` file ending. Internal policy functions have been moved to `policy_internal.sql`.
erimatnor
force-pushed
the
rename-cagg-policy
branch
from
05b0cef
to
3d4e442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits:
The first change simplifies the name of the functions for adding and
removing a continuous aggregate policy. The functions are renamed from:
add_refresh_continuous_aggregate_policyremove_refresh_continuous_aggregate_policyto
add_continuous_aggregate_policyremove_continuous_aggregate_policyThe second change restructures the SQL API for policies and jobs.
The SQL definitions for policy and job APIs are moved to their
separate files to improve code structure. Previously, all of these
user-visible API functions were located in the
bgw_scheduler.sqlfile, mixing internal and public functions and APIs.
To improved the structure, all API-related functions are now located
in their own distinct SQL files that have the
_api.sqlfileending. Internal policy functions have been moved to
policy_internal.sql.Fixes #2320