Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block chunks API internal #2381

Merged
merged 1 commit into from Sep 14, 2020

Conversation

erimatnor
Copy link
Contributor

This change moves the block chunks functionality to the internal
namespace since it won't be part of the public API for the 2.0
release.

Fixes #2236

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #2381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2381   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         212      212           
  Lines       34924    34924           
=======================================
  Hits        30912    30912           
  Misses       4012     4012           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9539b9...a1cbfbd. Read the comment docs.

@erimatnor erimatnor marked this pull request as ready for review September 14, 2020 08:23
@erimatnor erimatnor requested a review from a team as a code owner September 14, 2020 08:23
This change moves the block chunks functionality to the internal
namespace since it won't be part of the public API for the 2.0
release.

Fixes timescale#2236
@k-rus k-rus mentioned this pull request Sep 14, 2020
@erimatnor erimatnor merged commit 1068188 into timescale:master Sep 14, 2020
@erimatnor erimatnor deleted the make-block-chunks-internal branch September 14, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move block_new_chunks and allow_new_chunks to internal namespace
4 participants