Remove unused materializer code and completed threshold #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
changed the title
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
from
cdd08d9
to
df62925
Compare
erimatnor
added a commit
to erimatnor/timescaledb
that referenced
this pull request
Sep 14, 2020
This change filters materialized hypertables from the hypertables view, similar to how internal compression hypertables are filtered. Materialized hypertables are internal objects created as a side effect of creating a continuous aggregate, and these internal hypertables are still listed in the continuous_aggregates view. Fixes timescale#2382
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
2 times, most recently
from
ab124e2
to
7c72a39
Compare
erimatnor
added a commit
to erimatnor/timescaledb
that referenced
this pull request
Sep 14, 2020
This change filters materialized hypertables from the hypertables view, similar to how internal compression hypertables are filtered. Materialized hypertables are internal objects created as a side effect of creating a continuous aggregate, and these internal hypertables are still listed in the continuous_aggregates view. Fixes timescale#2382
erimatnor
added a commit
to erimatnor/timescaledb
that referenced
this pull request
Sep 14, 2020
This change filters materialized hypertables from the hypertables view, similar to how internal compression hypertables are filtered. Materialized hypertables are internal objects created as a side effect of creating a continuous aggregate, and these internal hypertables are still listed in the continuous_aggregates view. Fixes timescale#2382
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
2 times, most recently
from
9ba5afa
to
1daffc5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2382 +/- ##
==========================================
+ Coverage 88.91% 90.08% +1.16%
==========================================
Files 212 213 +1
Lines 34788 34299 -489
==========================================
- Hits 30932 30898 -34
+ Misses 3856 3401 -455
Continue to review full report at Codecov.
|
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
from
1daffc5
to
1452f3e
Compare
svenklemm
approved these changes
Sep 15, 2020
pmwkaa
approved these changes
Sep 15, 2020
mkindahl
approved these changes
Sep 15, 2020
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
4 times, most recently
from
6b6a425
to
2bf4ac3
Compare
This change cleans up and removes duplicate code for internal lookups of continuous aggregates. A number of related error messages have also been cleaned up and made conformant with the error style guide.
The new refresh functionality for continuous aggregates replaces the old materializer, which means some code is no longer used and should be removed. Closes timescale#2395
The completed threshold in the TimescaleDB catalog is no longer used by the refactored continuous aggregates, so it is removed. Fixes timescale#2178
erimatnor
force-pushed
the
caggs-cleanup-old-code
branch
from
2bf4ac3
to
6251a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old materializer, which means some code is no longer used and should
be removed.
by the refactored continuous aggregates, so it is removed.
of continuous aggregates. A number of related error messages have also
been cleaned up and made conformant with the error style guide.
Fixes #2178
Closes #2395