Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter materialized hypertables in view #2384

Merged
merged 1 commit into from Sep 14, 2020
Merged

Filter materialized hypertables in view #2384

merged 1 commit into from Sep 14, 2020

Conversation

erimatnor
Copy link
Contributor

@erimatnor erimatnor commented Sep 14, 2020 •
edited

This change filters materialized hypertables from the hypertables
view, similar to how internal compression hypertables are
filtered.

Materialized hypertables are internal objects created as a side effect
of creating a continuous aggregate, and these internal hypertables are
still listed in the continuous_aggregates view.

Fixes #2383

@erimatnor erimatnor added this to the 2.0.0 milestone Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited

Codecov Report

Merging #2384 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2384      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.01%     
==========================================
  Files         212      212              
  Lines       34924    34926       +2     
==========================================
+ Hits        30912    30920       +8     
+ Misses       4012     4006       -6
Impacted Files Coverage Δ
src/process_utility.c 91.76% <100.00%> (+0.65%) ⬆️
src/loader/bgw_message_queue.c 84.51% <0.00%> (-2.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1068188...62f8c4d. Read the comment docs.

@erimatnor erimatnor marked this pull request as ready for review September 14, 2020 08:42
@erimatnor erimatnor requested a review from a team as a code owner September 14, 2020 08:42
@erimatnor erimatnor requested review from pmwkaa, k-rus, svenklemm and mkindahl and removed request for a team September 14, 2020 08:42
@erimatnor erimatnor force-pushed the caggs-avoid-show-mathyper-in-view branch 2 times, most recently from 7ecc0ee to 41b712c Compare September 14, 2020 08:46
@pmwkaa
Copy link
Contributor

pmwkaa commented Sep 14, 2020 •
edited

@erimatnor to note: unless intentional, link in the description points to a pull request.

k-rus
k-rus approved these changes Sep 14, 2020
View reviewed changes
sql/views.sql
@@ -38,7 +40,7 @@ CREATE OR REPLACE VIEW timescaledb_information.hypertables AS
GROUP BY hypertable_id) dn
ON ht.id = dn.hypertable_id
WHERE ht.compressed is false --> no internal compression tables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not direct part of PR, but can you fix capitalisation of the keywords, since it is related and was overlooked in the correct PR review?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is prevalent throughout the SQL code. I suggest we adopt a formatter and make sure this is fixed in all places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is next to your line, so it was an obvious and easy fix, taking in account that you were fixing commit message and rebase in any case. Postponing is also fine (it just looked to me weird to have two lines next to each other in different style).

@k-rus
Copy link
Contributor

k-rus commented Sep 14, 2020

@erimatnor I agree with @pmwkaa that the commit message should link to an issue, which it fixes, not to a PR.

@erimatnor erimatnor force-pushed the caggs-avoid-show-mathyper-in-view branch from 41b712c to 0e8464a Compare September 14, 2020 09:02
@erimatnor
Copy link
Contributor Author

@erimatnor to note: unless intentional, link in the description points to a pull request.

Fixed!

@k-rus k-rus mentioned this pull request Sep 14, 2020
Merged
@erimatnor
Filter materialized hypertables in view
62f8c4d 
This change filters materialized hypertables from the hypertables
view, similar to how internal compression hypertables are
filtered.

Materialized hypertables are internal objects created as a side effect
of creating a continuous aggregate, and these internal hypertables are
still listed in the continuous_aggregates view.

Fixes timescale#2383
@erimatnor erimatnor force-pushed the caggs-avoid-show-mathyper-in-view branch from 0e8464a to 62f8c4d Compare September 14, 2020 10:05
@erimatnor erimatnor merged commit 4f74262 into timescale:master Sep 14, 2020
@erimatnor erimatnor deleted the caggs-avoid-show-mathyper-in-view branch September 14, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-rus k-rus k-rus approved these changes

@pmwkaa pmwkaa pmwkaa approved these changes

@mkindahl mkindahl mkindahl approved these changes

@svenklemm svenklemm svenklemm approved these changes

Assignees
No one assigned
Labels
continuous_aggregate
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Do not show materialized hypertables in the hypertables view
5 participants
@erimatnor @pmwkaa @k-rus @mkindahl @svenklemm