Error on create continuous aggregate with data #2389
Conversation
mkindahl
force-pushed
the
cagg_crash
branch
from
006f140
to
29db351
Compare
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 212 212
Lines 34924 34928 +4
==========================================
+ Hits 30912 30922 +10
+ Misses 4012 4006 -6
Continue to review full report at Codecov.
|
| FROM conditions | ||
| GROUP BY 1,2 WITH DATA; | ||
| END $$; | ||
| ERROR: CREATE MATERIALIZED VIEW ... WITH DATA cannot be executed from a function |
There was a problem hiding this comment.
This is slightly odd message, why we had to wrap it into the DO statement?
There was a problem hiding this comment.
Agree, but it's the standard message that PreventInTransactionBlock prints. It digs out the context itself, and uses the format %s cannot be .....
| \set ON_ERROR_STOP 0 | ||
| DO | ||
| LANGUAGE PLPGSQL | ||
| $$ DECLARE ts_version TEXT; |
There was a problem hiding this comment.
What does this DECLARE do? Seem like a copy-paste leftover.
| -- This should fail since we do not allow refreshing inside a | ||
| -- transaction, not even as part of CREATE MATERIALIZED VIEW. | ||
| \set ON_ERROR_STOP 0 | ||
| DO |
There was a problem hiding this comment.
Can't we just do a regular BEGIN--- COMMIT; transaction block instead of creating a function block. At least it would be good to test that case as well.
There was a problem hiding this comment.
And it will likely change the error message as well
There was a problem hiding this comment.
Done that as well.
| -- aggregate. | ||
| DO | ||
| LANGUAGE PLPGSQL | ||
| $$ DECLARE ts_version TEXT; |
There was a problem hiding this comment.
Another declare block and variable that is never used.
If a continuous aggregate is created using `CREATE MATERIALIZED VIEW` using the `WITH DATA` option, it will fail with a segmentation fault if executed inside a transaction or block. This is because starting a new transaction in the middle of the statement will reset the SPI stack. This commit fixes this by raising an error if `CREATE MATERIALIZED VIEW` is not executed on top-level and `WITH DATA` is used either directly or indirectly. Closes timescale#2371
mkindahl
force-pushed
the
cagg_crash
branch
from
29db351
to
dc625a2
Compare
If a continuous aggregate is created using
CREATE MATERIALIZED VIEWusing the
WITH DATAoption, it will fail with a segmentation fault ifexecuted inside a transaction or block. This is because starting a new
transaction in the middle of the statement will reset the SPI stack.
This commit fixes this by raising an error if
CREATE MATERIALIZED VIEWis not executed on top-level andWITH DATAis used eitherdirectly or indirectly.
Closes #2371