Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove continuous_aggregate_stats view #2390

Merged
merged 1 commit into from Sep 14, 2020

Conversation

gayyappan
Copy link
Contributor

@gayyappan gayyappan commented Sep 14, 2020

Reviewers:
see continuous_aggs_bgw.sql on how to query stats for continuous aggregates

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #2390 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   88.51%   88.89%   +0.38%     
==========================================
  Files         212      212              
  Lines       34924    34788     -136     
==========================================
+ Hits        30912    30924      +12     
+ Misses       4012     3864     -148     
Impacted Files Coverage Δ
src/continuous_agg.c 89.31% <ø> (ø)
tsl/src/continuous_aggs/options.c 94.59% <ø> (+71.42%) ⬆️
src/process_utility.c 93.64% <100.00%> (+2.53%) ⬆️
tsl/src/continuous_aggs/create.c 96.93% <100.00%> (+0.33%) ⬆️
tsl/src/fdw/shippable.c 82.85% <0.00%> (-11.43%) ⬇️
src/loader/bgw_message_queue.c 84.51% <0.00%> (-2.59%) ⬇️
src/hypertable.c 87.50% <0.00%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94dd9a3...145336f. Read the comment docs.

@gayyappan gayyappan marked this pull request as ready for review September 14, 2020 16:12
@gayyappan gayyappan requested a review from a team as a code owner September 14, 2020 16:12
@gayyappan gayyappan requested review from pmwkaa, k-rus, WireBaron and svenklemm and removed request for a team September 14, 2020 16:12
@gayyappan gayyappan force-pushed the cagg_stats_view branch 2 times, most recently from d06f68e to b19c25a Compare September 14, 2020 18:18
Stats for policies are exposed via
the policy_stats view. Remove continuous aggregate
stats view - the thresholds exposed via this
view are not relevant with the new API.
@gayyappan gayyappan merged commit 602d9a9 into timescale:master Sep 14, 2020
@gayyappan gayyappan deleted the cagg_stats_view branch October 5, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants