Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow REFRESH MATERIALIZED VIEW to refresh caggs #2391

Merged

Conversation

erimatnor
Copy link
Contributor

It is now possible to use REFRESH MATERIALIZED VIEW as an
alternative to refresh_continuous_aggregate when doing "infinite"
refreshes.

@erimatnor erimatnor added this to the 2.0.0 milestone Sep 14, 2020
@erimatnor erimatnor marked this pull request as ready for review September 14, 2020 14:50
@erimatnor erimatnor requested a review from a team as a code owner September 14, 2020 14:50
@erimatnor erimatnor requested review from pmwkaa, k-rus, WireBaron, mkindahl, cevian and a team and removed request for a team September 14, 2020 14:50
Copy link
Contributor

@cevian cevian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this interact with dropped data? It would be great if this refreshed everything /that hasn't been dropped/

@erimatnor
Copy link
Contributor Author

Note that this (temporarily) redirects REFRESH MATERIALIZED VIEW to the new refresh procedure instead of blocking. This is to avoid breaking existing update scripts while still having the command do something useful as opposed to calling the old materializer.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #2391 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
+ Coverage   88.51%   88.92%   +0.40%     
==========================================
  Files         212      212              
  Lines       34924    34788     -136     
==========================================
+ Hits        30912    30934      +22     
+ Misses       4012     3854     -158     
Impacted Files Coverage Δ
src/continuous_agg.c 89.31% <ø> (ø)
tsl/src/continuous_aggs/options.c 94.59% <ø> (+71.42%) ⬆️
src/process_utility.c 93.64% <100.00%> (+2.53%) ⬆️
tsl/src/continuous_aggs/create.c 96.93% <100.00%> (+0.33%) ⬆️
tsl/src/fdw/shippable.c 82.85% <0.00%> (-11.43%) ⬇️
src/loader/bgw_message_queue.c 84.51% <0.00%> (-2.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f1a0bd...f6a1a84. Read the comment docs.

@erimatnor erimatnor force-pushed the caggs-redirect-refresh-materialized-view branch from c662cab to 56f4991 Compare September 14, 2020 15:56
It is now possible to use `REFRESH MATERIALIZED VIEW` as an
alternative to `refresh_continuous_aggregate` when doing "infinite"
refreshes.
@erimatnor erimatnor force-pushed the caggs-redirect-refresh-materialized-view branch from 56f4991 to f6a1a84 Compare September 14, 2020 18:22
@erimatnor erimatnor merged commit 94dd9a3 into timescale:master Sep 14, 2020
@erimatnor erimatnor deleted the caggs-redirect-refresh-materialized-view branch September 14, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants