Fix failing isolation test on PG11.0 #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Early version of PG11 produces slightly different output for isolation tests. Thus the affected tests are ignored. continuous_aggs_concurrent_refresh is one of them and this commit adds it to the ignored test list.
pmwkaa
approved these changes
Sep 15, 2020
@pmwkaa The output between running on PG11.0 and PG11.7 is different for this test. So we ignore such tests on PG11.0 but run on latest PG11. I don't think it is worth the effort to build infrastructure, which will work in both cases. |
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 212 212
Lines 34788 34788
=======================================
Hits 30932 30932
Misses 3856 3856 Continue to review full report at Codecov.
|
gayyappan
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early version of PG11 produces slightly different output for isolation
tests. Thus the affected tests are ignored.
continuous_aggs_concurrent_refresh is one of them and this commit adds
it to the ignored test list.
PR comment:
Link to the failed test