Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ApacheOnly regression test #2411

Merged
merged 1 commit into from Sep 18, 2020
Merged

Conversation

svenklemm
Copy link
Member

The recently added test for hypertable detection used compression
which is not available in ApacheOnly tests so we use that test
to regresscheck-shared. Additionally we move the other test in
plan_hypertable_cache to plan_expand_hypertable to reduce the number
of tests.

@svenklemm svenklemm requested a review from a team as a code owner September 17, 2020 23:44
@svenklemm svenklemm requested review from pmwkaa, k-rus and gayyappan and removed request for a team September 17, 2020 23:44
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2411 into master will increase coverage by 1.19%.
The diff coverage is 98.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2411      +/-   ##
==========================================
+ Coverage   88.91%   90.10%   +1.19%     
==========================================
  Files         212      213       +1     
  Lines       34788    34304     -484     
==========================================
- Hits        30932    30911      -21     
+ Misses       3856     3393     -463     
Impacted Files Coverage Δ
src/catalog.c 84.70% <ø> (ø)
src/catalog.h 100.00% <ø> (ø)
src/cross_module_fn.c 58.13% <ø> (+1.32%) ⬆️
src/hypertable.c 87.42% <ø> (-0.08%) ⬇️
tsl/src/continuous_aggs/insert.c 87.23% <ø> (+0.15%) ⬆️
tsl/src/continuous_aggs/materialize.c 66.00% <ø> (+52.70%) ⬆️
tsl/src/init.c 88.88% <ø> (ø)
src/process_utility.c 93.59% <88.88%> (-0.05%) ⬇️
src/chunk.c 95.31% <100.00%> (-0.01%) ⬇️
src/continuous_agg.c 93.50% <100.00%> (+4.18%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2142f...6d45fd7. Read the comment docs.

@k-rus
Copy link
Contributor

k-rus commented Sep 18, 2020

decompress_placeholdervar fails on 32bit after the test was moved. There is some difference in a query plan.

@svenklemm svenklemm force-pushed the fix_apacheonly branch 2 times, most recently from ed9e16e to 1c30363 Compare September 18, 2020 17:29
The recently added test for hypertable detection used compression
which is not available in ApacheOnly tests so we move that test
to regresscheck-t. Additionally we move the other test in
plan_hypertable_cache to plan_expand_hypertable to reduce the number
of tests.
@svenklemm svenklemm merged commit 17cc6f6 into timescale:master Sep 18, 2020
@svenklemm svenklemm deleted the fix_apacheonly branch April 18, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants