Add test for dimensions view #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
reviewed
Sep 18, 2020
tsl/test/expected/dist_views.out
Outdated
| @@ -39,15 +39,22 @@ SELECT setseed(1); | |||
|
|
|||
| (1 row) | |||
|
|
|||
| CREATE TABLE dist_table(time timestamptz, device int, temp float); | |||
| CREATE TABLE dist_table(time timestamptz, device int, temp float, timdim date); | |||
There was a problem hiding this comment.
can you make time and timdim NOT NULL, this will get rid of the NOTICEs and remove some noise
gayyappan
force-pushed
the
bugfix
branch
2 times, most recently
from
16ebc27
to
bd016ce
Compare
svenklemm
reviewed
Sep 18, 2020
tsl/test/expected/dist_views.out
Outdated
| @@ -39,15 +39,20 @@ SELECT setseed(1); | |||
|
|
|||
| (1 row) | |||
|
|
|||
| CREATE TABLE dist_table(time timestamptz, device int, temp float); | |||
| CREATE TABLE dist_table(time timestamptz NOT NULL, device int, temp float, timdim date NOT NULL); | |||
There was a problem hiding this comment.
did you mean to call that column timedim instead of timdim just sounds a bit weird
svenklemm
approved these changes
Sep 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #2419 +/- ##
==========================================
+ Coverage 89.95% 90.13% +0.18%
==========================================
Files 213 213
Lines 34354 34328 -26
==========================================
+ Hits 30904 30943 +39
+ Misses 3450 3385 -65
Continue to review full report at Codecov.
|
WireBaron
approved these changes
Sep 18, 2020
pmwkaa
approved these changes
Sep 21, 2020
Create more than 2 dimensions and verify that dimensions view displays information correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create more than 2 dimensions and verify
that dimensions view displays information correctly.