Remove duplicate find_em_expr_for_rel function #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
mkindahl,
WireBaron and
gayyappan
and removed request for
a team
svenklemm
force-pushed
the
find_em_expr_for_rel
branch
from
78c0544
to
ba5431e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
+ Coverage 89.97% 90.10% +0.12%
==========================================
Files 213 213
Lines 34373 34316 -57
==========================================
- Hits 30928 30921 -7
+ Misses 3445 3395 -50
Continue to review full report at Codecov.
|
k-rus
approved these changes
Sep 20, 2020
The functions find_em_expr_for_rel and ts_find_em_expr_for_rel are identical. This patch removes find_em_expr_for_rel and changes all call-sites to use ts_find_em_expr_for_rel.
svenklemm
force-pushed
the
find_em_expr_for_rel
branch
from
8f384f7
to
8fe633a
Compare
Remove ts_dimension_info_create_open_interval_usec function because it was no longer used. This patch also moves the add_dimension record attribute numbers into the c file because it does not need to be exported.
pmwkaa
approved these changes
Sep 21, 2020
During refactoring continuous aggregates some function defintions for functions that got removed were not removed from the header file. Additionally a few other header files had function definitions that no longer had an implementation or macros that were not used.
svenklemm
force-pushed
the
find_em_expr_for_rel
branch
from
7975c1b
to
4dcc791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions find_em_expr_for_rel and ts_find_em_expr_for_rel are
identical. This patch removes find_em_expr_for_rel and changes all
call-sites to use ts_find_em_expr_for_rel.