Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused refresh arguments from invalidation #2441

Merged
merged 1 commit into from Sep 24, 2020

Conversation

k-rus
Copy link
Contributor

@k-rus k-rus commented Sep 24, 2020

After recent refactoring the refresh window arguments are not used in
many invalidation functions. This fixes the code and removes unused
arguments to avoid future confusions.

After recent refactoring the refresh window arguments are not used in
many invalidation functions. This fixes the code and removes unused
arguments to avoid future confusions.
@k-rus k-rus requested a review from a team as a code owner September 24, 2020 12:37
@k-rus k-rus requested review from pmwkaa, mkindahl, WireBaron and erimatnor and removed request for a team September 24, 2020 12:37
@k-rus k-rus self-assigned this Sep 24, 2020
Copy link
Contributor

@erimatnor erimatnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to fix this myself :) Great that I don't have to.

@k-rus
Copy link
Contributor Author

k-rus commented Sep 24, 2020

Was just about to fix this myself :) Great that I don't have to.

It was confusing me, so I decided to bring it outside my current work. I might need to do another refactoring change, so it is good to have it as a basis.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #2441 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2441   +/-   ##
=======================================
  Coverage   90.10%   90.11%           
=======================================
  Files         213      213           
  Lines       34336    34336           
=======================================
+ Hits        30940    30943    +3     
+ Misses       3396     3393    -3     
Impacted Files Coverage Δ
tsl/src/continuous_aggs/invalidation.c 98.16% <100.00%> (ø)
tsl/src/continuous_aggs/refresh.c 99.32% <100.00%> (ø)
src/loader/bgw_message_queue.c 87.09% <0.00%> (-0.65%) ⬇️
tsl/src/fdw/shippable.c 94.28% <0.00%> (+11.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb30e54...b83ca6a. Read the comment docs.

@k-rus k-rus merged commit 9fedb63 into timescale:master Sep 24, 2020
@k-rus k-rus deleted the invalidation-refresh-cleanup branch September 24, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants