Turn debug messages into DEBUG1

[mkindahl]

We have some debug messages that are printed as notices, but are more
suitable to have at DEBUG1 level. This commit removes a notice about
indexes being added and turns it into a DEBUG1 notice.

[svenklemm]

I think there are probably more candidates for this treatment.

[erimatnor]

FWIW, I think these log statements can be removed altogether. They served some purpose as NOTICEs to users, but as DEBUG1 messages I don't think they provide any useful information. If one wants to validate that these indexes exists, one need to check the table they get added to.

[mkindahl]

I think there are probably more candidates for this treatment.

Yeah, but if I take to many at a time, there is going to be a lot of discussions about some of them, which will just block progress. Better take it in smaller and more clear batches.

[mkindahl]

FWIW, I think these log statements can be removed altogether. They served some purpose as NOTICEs to users, but as DEBUG1 messages I don't think they provide any useful information. If one wants to validate that these indexes exists, one need to check the table they get added to.

I'm fine with removing them altogether, but I thought moving them to DEBUG1 might be less controversial.

[codecov]

Codecov Report

Merging #2443 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2443      +/-   ##
==========================================
+ Coverage   89.99%   90.11%   +0.11%     
==========================================
  Files         213      213              
  Lines       34406    34356      -50     
==========================================
- Hits        30964    30960       -4     
+ Misses       3442     3396      -46     

Impacted Files	Coverage Δ
src/copy.c	87.86% <ø> (-0.20%)	⬇️
src/indexing.c	94.87% <ø> (ø)
src/planner.c	93.80% <ø> (ø)
tsl/src/remote/dist_ddl.c	98.66% <ø> (ø)
src/cache_invalidate.c	84.44% <100.00%> (+0.72%)	⬆️
src/loader/bgw_launcher.c	89.53% <100.00%> (ø)
src/process_utility.c	93.70% <100.00%> (+<0.01%)	⬆️
tsl/src/compression/create.c	95.38% <100.00%> (ø)
tsl/src/continuous_aggs/create.c	96.91% <100.00%> (ø)
tsl/src/fdw/shippable.c	82.85% <0.00%> (-11.43%)	⬇️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11256b...ae57da1. Read the comment docs.