Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename policy_stats view #2461

Merged
merged 1 commit into from Sep 29, 2020
Merged

Rename policy_stats view #2461

merged 1 commit into from Sep 29, 2020

Conversation

gayyappan
Copy link
Contributor

Rename policy_stats view to job_stats

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2461 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.01%     
==========================================
  Files         213      213              
  Lines       34336    34356      +20     
==========================================
+ Hits        30940    30956      +16     
- Misses       3396     3400       +4     
Impacted Files Coverage Δ
src/copy.c 87.86% <ø> (-0.20%) ⬇️
src/indexing.c 94.87% <ø> (ø)
src/planner.c 93.80% <ø> (ø)
tsl/src/remote/dist_ddl.c 98.66% <ø> (ø)
src/cache_invalidate.c 84.44% <100.00%> (+0.72%) ⬆️
src/loader/bgw_launcher.c 89.53% <100.00%> (ø)
src/process_utility.c 93.70% <100.00%> (+0.05%) ⬆️
tsl/src/compression/create.c 95.38% <100.00%> (ø)
tsl/src/continuous_aggs/create.c 96.91% <100.00%> (ø)
tsl/src/continuous_aggs/invalidation.c 98.18% <100.00%> (+0.02%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ad8b4...394a1c0. Read the comment docs.

@gayyappan gayyappan marked this pull request as ready for review September 28, 2020 20:12
@gayyappan gayyappan requested a review from a team as a code owner September 28, 2020 20:12
@gayyappan gayyappan requested review from mkindahl, WireBaron and svenklemm and removed request for a team September 28, 2020 20:12
@@ -272,7 +272,7 @@ select view_name, view_definition from timescaledb_information.continuous_aggreg
where view_name::text like '%test_continuous_agg_view';

select job_status, last_run_duration
from timescaledb_information.policy_stats ps, timescaledb_information.continuous_aggregates cagg
from timescaledb_information.job_stats ps, timescaledb_information.continuous_aggregates cagg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: still using ps as a name

Rename policy_stats view to job_stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants