Block REFRESH MATERIALIZED VIEW on caggs #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
erimatnor,
mkindahl and
k-rus
and removed request for
a team
svenklemm
force-pushed
the
fresh_mat_view
branch
3 times, most recently
from
5a3d452
to
11cd2d0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
==========================================
+ Coverage 89.99% 90.12% +0.12%
==========================================
Files 213 213
Lines 34406 34350 -56
==========================================
- Hits 30964 30958 -6
+ Misses 3442 3392 -50
Continue to review full report at Codecov.
|
mkindahl
approved these changes
Sep 29, 2020
Comment on lines
+3405
to
+3412
| if (cagg) | ||
| ereport(ERROR, | ||
| (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), | ||
| errmsg("operation not supported on continuous aggregate"), | ||
| errdetail("A continuous aggregate does not support REFRESH MATERIALIZED VIEW."), | ||
| errhint("Use \"refresh_continuous_aggregate\" or set up a policy to refresh the " | ||
| "continuous aggregate."))); |
There was a problem hiding this comment.
No test coverage for this piece of code. Add a test?
Comment on lines
240
to
242
| -- Test that REFRESH MATERIALIZED VIEW works as an alternative to | ||
| -- refresh_continuous_aggregate() | ||
| REFRESH MATERIALIZED VIEW weekly_temp_without_data; |
There was a problem hiding this comment.
You could keep this REFRESH and just check that it generates an error.
k-rus
reviewed
Sep 29, 2020
svenklemm
force-pushed
the
fresh_mat_view
branch
4 times, most recently
from
670d38e
to
f37eb1c
Compare
svenklemm
force-pushed
the
fresh_mat_view
branch
from
f37eb1c
to
a566f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.