Use postgres implementation of estimate_hashagg_tablesize #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
k-rus,
WireBaron and
gayyappan
and removed request for
a team
svenklemm
force-pushed
the
estimate_hashagg_tablesize
branch
from
4259951
to
a4d51b0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2467 +/- ##
==========================================
+ Coverage 89.99% 90.16% +0.16%
==========================================
Files 213 212 -1
Lines 34406 34124 -282
==========================================
- Hits 30964 30768 -196
+ Misses 3442 3356 -86
Continue to review full report at Codecov.
|
WireBaron
approved these changes
Sep 29, 2020
k-rus
approved these changes
Sep 30, 2020
src/compat.h
Outdated
Comment on lines
299
to
300
| * estimate_hashagg_tablesize is a static function in PG11 and earlier so we map | ||
| * to our own copy when it's not available |
There was a problem hiding this comment.
Suggested change
| * estimate_hashagg_tablesize is a static function in PG11 and earlier so we map | |
| * to our own copy when it's not available | |
| * estimate_hashagg_tablesize is a static function in PG11 and earlier, so we map | |
| * to our own copy when it's not available. |
pmwkaa
approved these changes
Sep 30, 2020
Only use our own implementation of estimate_hashagg_tablesize on versions where the postgres implementation is static.
svenklemm
force-pushed
the
estimate_hashagg_tablesize
branch
from
a4d51b0
to
0e87833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use our own implementation of estimate_hashagg_tablesize on
versions where the postgres implementation is static.