Test Apache license on Windows

[k-rus]

Fixes the regression test of Apache license on Windows.

PR note

GH is confused by some reason and shows difference on number of unchanged lines.

#2435 removed the Apache license test on Windows. This PR fixes it back.

[codecov]

Codecov Report

Merging #2470 into master will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   90.04%   90.15%   +0.10%     
==========================================
  Files         212      212              
  Lines       34174    34124      -50     
==========================================
- Hits        30772    30764       -8     
+ Misses       3402     3360      -42     

Impacted Files	Coverage Δ
tsl/src/fdw/shippable.c	82.85% <0.00%> (-11.43%)	⬇️
src/loader/bgw_message_queue.c	84.51% <0.00%> (-2.59%)	⬇️
src/import/planner.c	70.30% <0.00%> (+11.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb4c8f...b8e60b5. Read the comment docs.

[pmwkaa]

@k-rus Funny that I've tried exact same approach, did not worked for some reason, probably missed something. Hope it will now.

The changed lines might be to the reason that Windows text files are usually use different end of line chars (\r\n vs \n). Maybe they have changed accidentally?

[erimatnor]

There's a lot of lines that seem unrelated to the changes in this PR, which makes it harder to review. I actually only identified three lines that seem relevant. Would be good to keep formatting as a separate change.

[k-rus]

There's a lot of lines that seem unrelated to the changes in this PR, which makes it harder to review. I actually only identified three lines that seem relevant. Would be good to keep formatting as a separate change.

@erimatnor See my not in #2470 (comment)
I haven't done any changes to these lines. It might be due to git settings, I am checking it.

[mkindahl]

Looks good, but would be good to just have changed lines. There is no difference between some of the changed lines, so I suspect that it is a change in line ending as a result of the editor being helpful.

[pmwkaa]

Apparently license tests passed, so this change makes sense. Yet there are some odd issues with other tests, likely not related to this PR

[k-rus]

@pmwkaa @erimatnor @mkindahl I made a comment in the OP of the PR regarding unrelated lines. I guess nobody reads it:

GH is confused by some reason and shows difference on number of unchanged lines.

One explanation can be that git silently fixes the line endings. I have not set the configuration, so it is default behaviour.

[k-rus]

Apparently license tests passed, so this change makes sense. Yet there are some odd issues with other tests, likely not related to this PR

@pmwkaa You are right the failures are not related to the PR, so I created an issue for the deterministic failures.

Funny that I've tried exact same approach, did not worked for some reason, probably missed something. Hope it will now.

You might not put in exactly the same place. It needs to be before the PG service is started or restarted.