Remove unreferenced steps from isolation tests #2487
Conversation
svenklemm
requested review from
pmwkaa,
mkindahl and
gayyappan
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #2487 +/- ##
==========================================
+ Coverage 90.07% 90.19% +0.12%
==========================================
Files 212 212
Lines 34198 34148 -50
==========================================
- Hits 30805 30801 -4
+ Misses 3393 3347 -46
Continue to review full report at Codecov.
|
| { | ||
| LOCK _timescaledb_catalog.continuous_aggs_invalidation_threshold | ||
| IN ACCESS EXCLUSIVE MODE; | ||
| } | ||
| step "L1_unlock_threshold_table" |
There was a problem hiding this comment.
If the lock step is removed, then we shouldn't need the unlock either.
There was a problem hiding this comment.
removing the unlock does alter the test and leads to different test output
| step "S1" { SELECT count(*) from ts_device_table; } | ||
| step "SC1" { SELECT count(*) from _timescaledb_internal._hyper_1_1_chunk; } | ||
| step "SH" { SELECT total_chunks, number_compressed_chunks from hypertable_compression_stats('ts_device_table'); } | ||
| step "Sc" {COMMIT;} |
There was a problem hiding this comment.
If this is missing from the sequences below, is not that an error in itself?
There was a problem hiding this comment.
this PR only removes dead code, and an isolation test session is not required to be in a single transaction, to check progress in a session it's actually required not to run in transaction due to MVCC
There was a problem hiding this comment.
Well... yes, but why was the commit there to begin with if it was not needed?
Some isolation tests had steps that were not referenced in any of the permutations so this patch removes those.
Some isolation tests had steps that were not referenced in
any of the permutations so this patch removes those.