Make data nodes view consistent with other views #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
fix-data-nodes-view-name
branch
from
c3807a2
to
84bf5de
Compare
Rename the data_node view to data_nodes to be consistent with other views that all use the plural form.
erimatnor
force-pushed
the
fix-data-nodes-view-name
branch
from
84bf5de
to
a081a30
Compare
pmwkaa
approved these changes
Oct 5, 2020
k-rus
approved these changes
Oct 5, 2020
mkindahl
approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #2490 +/- ##
==========================================
+ Coverage 90.08% 90.18% +0.09%
==========================================
Files 212 212
Lines 34198 34148 -50
==========================================
- Hits 30808 30795 -13
+ Misses 3390 3353 -37
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the data_node view to data_nodes to be consistent with other
views that all use the plural form.