Add if_attached argument to detach_data_node() #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmwkaa
requested review from
WireBaron,
svenklemm,
gayyappan and
a team
and removed request for
a team
This change makes detach_data_node() function consistent with other data node management functions by adding missing if_attach argument. The function will not show an error in case if data node is not attached and if_attached is set to true. Issue: timescale#2506
pmwkaa
force-pushed
the
detach_if_attached
branch
from
a62c24b
to
8bcae3f
Compare
mkindahl
approved these changes
Oct 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #2515 +/- ##
==========================================
+ Coverage 90.08% 90.16% +0.07%
==========================================
Files 212 212
Lines 34198 34175 -23
==========================================
+ Hits 30808 30814 +6
+ Misses 3390 3361 -29
Continue to review full report at Codecov.
|
WireBaron
approved these changes
Oct 8, 2020
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide * timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * timescale#2520 Support non-transactional distibuted_exec **Bugfixes** * timescale#2307 Overflow handling for refresh policy with integer time * timescale#2503 Remove error for correct bootstrap of data node * timescale#2507 Fix validation logic when adding a new data node * timescale#2510 Fix outer join qual propagation * timescale#2514 Lock dimension slices when creating new chunk * timescale#2515 Add if_attached argument to detach_data_node() * timescale#2517 Fix member access within misaligned address in chunk_update_colstats * timescale#2525 Fix index creation on hypertables with dropped columns * timescale#2543 Pass correct status to lock_job * timescale#2544 Assume custom time type range is same as bigint * timescale#2563 Fix DecompressChunk path generation * timescale#2564 Improve continuous aggregate datatype handling * timescale#2568 Change use of ssl_dir GUC * timescale#2571 Make errors and messages conform to style guide * timescale#2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm
added a commit
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm
added a commit
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
svenklemm
added a commit
that referenced
this pull request
Oct 20, 2020
This release candidate contains bugfixes since the previous release candidate. **Minor Features** * #2520 Support non-transactional distibuted_exec **Bugfixes** * #2307 Overflow handling for refresh policy with integer time * #2503 Remove error for correct bootstrap of data node * #2507 Fix validation logic when adding a new data node * #2510 Fix outer join qual propagation * #2514 Lock dimension slices when creating new chunk * #2515 Add if_attached argument to detach_data_node() * #2517 Fix member access within misaligned address in chunk_update_colstats * #2525 Fix index creation on hypertables with dropped columns * #2543 Pass correct status to lock_job * #2544 Assume custom time type range is same as bigint * #2563 Fix DecompressChunk path generation * #2564 Improve continuous aggregate datatype handling * #2568 Change use of ssl_dir GUC * #2571 Make errors and messages conform to style guide * #2577 Exclude compressed chunks from ANALYZE/VACUUM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes detach_data_node() function consistent with
other data node management functions by adding missing
if_attach argument.
The function will not show an error in case if data node is not
attached and if_attached is set to true.
Issue: #2506