Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check function linkage in update test #2534

Merged
merged 2 commits into from Oct 13, 2020

Conversation

svenklemm
Copy link
Member

This patch adds a check that all c functions link to the correct
library after an update.

@svenklemm svenklemm requested a review from a team as a code owner October 12, 2020 14:33
@svenklemm svenklemm requested review from pmwkaa, k-rus, gayyappan, erimatnor, mkindahl and WireBaron and removed request for a team October 12, 2020 14:33
@svenklemm
Copy link
Member Author

Needs fdw fixes to pass tests

@svenklemm svenklemm added this to the 2.0.0 milestone Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #2534 into master will increase coverage by 0.14%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2534      +/-   ##
==========================================
+ Coverage   90.05%   90.20%   +0.14%     
==========================================
  Files         212      212              
  Lines       34225    34178      -47     
==========================================
+ Hits        30822    30829       +7     
+ Misses       3403     3349      -54     
Impacted Files Coverage Δ
src/compat.h 100.00% <ø> (ø)
tsl/src/remote/dist_commands.c 92.61% <75.00%> (+0.12%) ⬆️
tsl/src/fdw/shippable.c 82.85% <0.00%> (-11.43%) ⬇️
src/loader/bgw_message_queue.c 87.09% <0.00%> (ø)
src/loader/bgw_launcher.c 92.00% <0.00%> (+2.46%) ⬆️
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8203f...8e6a967. Read the comment docs.

@svenklemm svenklemm force-pushed the update_linkage branch 4 times, most recently from 797607a to c487d4e Compare October 13, 2020 14:47
This patch adds a check that all c functions link to the correct
library after an update.
Refactor update test files and remove obsolete test files.
@svenklemm svenklemm merged commit 4b4db04 into timescale:master Oct 13, 2020
@svenklemm svenklemm deleted the update_linkage branch April 18, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants