Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version number verification to allow releases #2755

Merged
merged 1 commit into from Dec 18, 2020

Conversation

k-rus
Copy link
Contributor

@k-rus k-rus commented Dec 18, 2020

The verification of version number in version.config required
pre-release label always. This fixes the bug and allows release versions.

@k-rus k-rus requested a review from a team as a code owner December 18, 2020 10:23
@k-rus k-rus requested review from pmwkaa, erimatnor, svenklemm, mkindahl and gayyappan and removed request for a team December 18, 2020 10:23
@k-rus k-rus force-pushed the fix-version-config branch 2 times, most recently from 73038d5 to 2cb1492 Compare December 18, 2020 10:36
The verification of version number in version.config required
pre-release label always. This fixes the bug and allows release versions.
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #2755 (845937d) into master (d13afc7) will increase coverage by 0.12%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2755      +/-   ##
==========================================
+ Coverage   90.12%   90.24%   +0.12%     
==========================================
  Files         212      212              
  Lines       34640    34614      -26     
==========================================
+ Hits        31218    31237      +19     
+ Misses       3422     3377      -45     
Impacted Files Coverage Δ
tsl/src/dist_util.c 93.28% <ø> (ø)
tsl/src/remote/connection.c 91.57% <88.57%> (-0.56%) ⬇️
tsl/src/data_node.c 96.25% <100.00%> (+0.02%) ⬆️
src/loader/bgw_message_queue.c 87.09% <0.00%> (ø)
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21d863...845937d. Read the comment docs.

@k-rus k-rus merged commit c7a12d1 into timescale:master Dec 18, 2020
@k-rus k-rus deleted the fix-version-config branch December 18, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants