Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coverity build to not use -Werror #2760

Merged
merged 1 commit into from Dec 18, 2020

Conversation

mkindahl
Copy link
Contributor

The coverity build should not build with warnings-as-errors, so
disabling it for the build.

The coverity build should not build with warnings-as-errors, so
disabling it for the build.
@mkindahl mkindahl requested a review from a team as a code owner December 18, 2020 15:13
@mkindahl mkindahl requested review from erimatnor, svenklemm, gayyappan and k-rus and removed request for a team, svenklemm and gayyappan December 18, 2020 15:13
@mkindahl
Copy link
Contributor Author

Building using coverity to check that it works: https://github.com/timescale/timescaledb/actions/runs/430736407

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #2760 (920ec24) into master (d13afc7) will increase coverage by 0.11%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2760      +/-   ##
==========================================
+ Coverage   90.12%   90.24%   +0.11%     
==========================================
  Files         212      212              
  Lines       34640    34614      -26     
==========================================
+ Hits        31218    31236      +18     
+ Misses       3422     3378      -44     
Impacted Files Coverage Δ
tsl/src/dist_util.c 93.28% <ø> (ø)
tsl/src/remote/connection.c 91.57% <88.57%> (-0.56%) ⬇️
tsl/src/data_node.c 96.25% <100.00%> (+0.02%) ⬆️
tsl/src/data_node_dispatch.c 97.02% <0.00%> (-0.25%) ⬇️
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a12d1...920ec24. Read the comment docs.

@mkindahl mkindahl merged commit a2275c7 into timescale:master Dec 18, 2020
@mkindahl mkindahl deleted the fix_coverity_build branch December 18, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants