Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AT_DropExpression in process_utility #2796

Merged
merged 1 commit into from Jan 11, 2021

Conversation

svenklemm
Copy link
Member

PG13 adds a new ALTER TABLE subcommand for dropping the generated
property from a column.

postgres/postgres@f595117e24

@svenklemm svenklemm requested a review from a team as a code owner January 8, 2021 13:32
@svenklemm svenklemm requested review from pmwkaa, erimatnor, gayyappan, mkindahl and k-rus and removed request for a team January 8, 2021 13:32
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #2796 (3b3bdb5) into master (6cc9871) will increase coverage by 0.21%.
The diff coverage is 92.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
+ Coverage   90.01%   90.23%   +0.21%     
==========================================
  Files         213      212       -1     
  Lines       34402    34620     +218     
==========================================
+ Hits        30968    31240     +272     
+ Misses       3434     3380      -54     
Impacted Files Coverage Δ
src/bgw/job_stat.c 86.80% <0.00%> (ø)
src/catalog.h 100.00% <ø> (ø)
src/chunk.h 100.00% <ø> (ø)
src/compat.h 100.00% <ø> (ø)
src/compression_with_clause.c 87.06% <ø> (ø)
src/extension_utils.c 81.39% <ø> (ø)
src/import/planner.c 70.30% <ø> (+11.12%) ⬆️
src/indexing.c 96.15% <ø> (+1.28%) ⬆️
src/jsonb_utils.c 81.70% <ø> (-4.88%) ⬇️
src/loader/bgw_message_queue.c 87.09% <ø> (ø)
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b3ad1...3b3bdb5. Read the comment docs.

Copy link
Contributor

@gayyappan gayyappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would be good to add a test case for this.

Copy link
Contributor

@pmwkaa pmwkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for test case, if possible

PG13 adds a new ALTER TABLE subcommand for dropping the generated
property from a column.

postgres/postgres@f595117e24
@svenklemm svenklemm merged commit 44edb25 into timescale:master Jan 11, 2021
@svenklemm svenklemm deleted the pg_at_dropexpr branch April 18, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants