Run regresscheck on PG13 #2836
Merged
Run regresscheck on PG13 #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
force-pushed
the
pg13_regresscheck
branch
3 times, most recently
from
aac875d
to
6762faf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2836 +/- ##
==========================================
+ Coverage 90.08% 90.24% +0.15%
==========================================
Files 212 212
Lines 34775 34725 -50
==========================================
+ Hits 31326 31336 +10
+ Misses 3449 3389 -60
Continue to review full report at Codecov.
|
svenklemm
force-pushed
the
pg13_regresscheck
branch
4 times, most recently
from
55f8c10
to
2e494f8
Compare
svenklemm
force-pushed
the
pg13_regresscheck
branch
3 times, most recently
from
fbd9e31
to
8b0c8f2
Compare
svenklemm
force-pushed
the
pg13_regresscheck
branch
from
8b0c8f2
to
c7d0f35
Compare
mkindahl
reviewed
Jan 26, 2021
There was a problem hiding this comment.
I compared the output files for PG12 and PG13 to see that there were only benign changes. Here's a summary:
- These tests are identical in PG12 and PG13:
custom_type,multi_transaction_index,parallel,partition,chunk_adaptive,plan_hashagg,query,sql_query - These tests have new names in the plans, but otherwise match:
delete,plan_expand_hypertable,plan_hypertable_inline,update - Test
partitionwisehave some changes in plans, please check below and verify that they are OK. - These tests have changes in error messages:
constraint,ddl,insert
svenklemm
force-pushed
the
pg13_regresscheck
branch
from
c7d0f35
to
499e9f7
Compare
PG13 adds the relation name to constraint errors making the output differ from previous PG versions.
PG13 changes relation alias naming in EXPLAIN output making the output different from previous versions.
PG13 changes relation alias naming in EXPLAIN output making the output different from previous versions.
PG13 changes relation alias naming in EXPLAIN output making the output different from previous versions.
PG13 changes the error message on constraint validation to include the relation making the error message different from previous PG versions.
PG13 adds the relation to constraint violation error messages making the test output different from previous PG versions.
PG13 changes the relation name aliasing in EXPLAIN output making explain output different from previous PG versions.
The order of relations of cluster is different on PG13 compared to previous versions.
svenklemm
force-pushed
the
pg13_regresscheck
branch
from
499e9f7
to
d769159
Compare
mkindahl
approved these changes
Jan 29, 2021
gayyappan
reviewed
Jan 29, 2021
| ----------------------------------------------------------------------------------------------------------------------------------------------------- | ||
| Limit | ||
| Output: (time_func(_hyper_3_7_chunk."time")), _hyper_3_7_chunk.device, (avg(_hyper_3_7_chunk.temp)) | ||
| -> GroupAggregate |
There was a problem hiding this comment.
I see some of the HashAggregate became GroupAggregates (for thsi file) in PG13. Do we need to set enable_hashagg = false here to ensure that plans will not change?
There was a problem hiding this comment.
i think the groupagg plans are preferable and i think we dont care what type of aggregation postgres uses here and the test is already pg-version specific so it should be stable
gayyappan
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.