Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI coredump detection #2862

Merged
merged 1 commit into from Jan 26, 2021
Merged

Conversation

svenklemm
Copy link
Member

Occasionally tests would segfault but the coredump would not be
uploaded as artefact because the coredump was still in progress.
This patch changes CI to wait for potential in progress coredumps
to upload coredumps more reliably.

Occasionally tests would segfault but the coredump would not be
uploaded as artefact because the coredump was still in progress.
This patch changes CI to wait for potential in progress coredumps
to upload coredumps more reliably.
@svenklemm svenklemm requested a review from a team as a code owner January 25, 2021 18:28
@svenklemm svenklemm requested review from erimatnor, k-rus and gayyappan and removed request for a team January 25, 2021 18:29
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #2862 (6aec096) into master (b1dc030) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
+ Coverage   90.08%   90.19%   +0.11%     
==========================================
  Files         212      212              
  Lines       34772    34722      -50     
==========================================
- Hits        31324    31318       -6     
+ Misses       3448     3404      -44     
Impacted Files Coverage Δ
src/chunk_append/planner.c 93.44% <100.00%> (ø)
src/loader/bgw_message_queue.c 84.51% <0.00%> (-3.23%) ⬇️
tsl/src/data_node_dispatch.c 97.02% <0.00%> (-0.25%) ⬇️
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302de38...6aec096. Read the comment docs.

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best would be if there is any way to check that a coredump is expected (e.g., checking the signal of the crashed pid), but there seems to be no easy way to do this. My worry is that 10 seconds is not enough, but at least this will improve the situation, so approving.

@svenklemm svenklemm merged commit dc3561d into timescale:master Jan 26, 2021
@svenklemm svenklemm deleted the gh_coredumps branch April 18, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants