Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run regresscheck-shared on appveyor #3007

Merged
merged 3 commits into from Mar 9, 2021

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm requested a review from a team as a code owner March 5, 2021 17:02
@svenklemm svenklemm requested review from mkindahl, nikkhils and gayyappan and removed request for a team March 5, 2021 17:02
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #3007 (183d527) into master (f0675be) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
+ Coverage   90.30%   90.34%   +0.03%     
==========================================
  Files         213      210       -3     
  Lines       35004    34692     -312     
==========================================
- Hits        31610    31341     -269     
+ Misses       3394     3351      -43     
Impacted Files Coverage Δ
src/loader/bgw_launcher.c 89.50% <0.00%> (-2.50%) ⬇️
src/chunk_dispatch_state.c 93.10% <0.00%> (-2.20%) ⬇️
tsl/src/nodes/decompress_chunk/planner.c 96.29% <0.00%> (-0.75%) ⬇️
src/import/planner.c 69.73% <0.00%> (-0.57%) ⬇️
src/plan_expand_hypertable.c 93.65% <0.00%> (-0.55%) ⬇️
src/scanner.c 95.76% <0.00%> (-0.51%) ⬇️
tsl/src/fdw/data_node_scan_plan.c 97.15% <0.00%> (-0.48%) ⬇️
tsl/src/compression/gorilla.c 91.19% <0.00%> (-0.39%) ⬇️
tsl/test/src/remote/remote_exec.c 92.00% <0.00%> (-0.31%) ⬇️
src/planner.c 93.25% <0.00%> (-0.29%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36099a...183d527. Read the comment docs.

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but you might want to consider switching scheme for database names.

tsl/test/sql/remote_connection_cache.sql Outdated Show resolved Hide resolved
@svenklemm svenklemm force-pushed the appveyor-shared branch 14 times, most recently from 3cbe2c4 to bebbdc8 Compare March 9, 2021 09:47
Change the telemetry_distributed test to not use hardcoded database
names but instead derive it from test name. This patch also changes
the test to drop any databases created by the test itself.
This patch makes TEST_PGPORT available in the environment pg_regress
is run on and changes pg_regress to drop the test tablespaces at
the end of the run to get a clean state for installchecklocal runs.
@svenklemm svenklemm merged commit 1d6b498 into timescale:master Mar 9, 2021
@svenklemm svenklemm deleted the appveyor-shared branch April 18, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants