Add declaration before code to guidelines #3032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
requested review from
nikkhils,
svenklemm and
mfundul
and removed request for
a team
mfundul
approved these changes
Mar 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #3032 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 213 213
Lines 35004 35004
=======================================
Hits 31601 31601
Misses 3403 3403
Continue to review full report at Codecov.
|
|
Is the idea to support it from now on? |
We already have code in the repository with this, so nothing really changes. We are just documenting the guideline. |
svenklemm
reviewed
Mar 17, 2021
docs/StyleGuide.md
Outdated
| @@ -37,6 +37,21 @@ elaborates on the situation. Instead, we've tried our best to develop | |||
| a consistent style that roughly follows the style of the PostgreSQL | |||
| source code. | |||
|
|
|||
| ### Declarations before code | |||
|
|
|||
| C99 support having code before a declaration, similar to C++, and we | |||
svenklemm
approved these changes
Mar 17, 2021
Declarations before code has been informally supported and we have several examples in the code. This commit adds that guideline to the coding guidelines.
mkindahl
force-pushed
the
coding_guidelines
branch
from
2b1c0e2
to
38fa10b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarations before code has been informally supported and we have
several examples in the code. This commit adds that guideline to the
coding guidelines.