Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Hypertable argument from ts_constraint_aware_append_path_create #3064

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Mar 26, 2021

The hypertable argument to ts_constraint_aware_append_path_create was
never actually used in the function so this patch removes it.

Disable-check: commit-count

@svenklemm svenklemm requested a review from a team as a code owner March 26, 2021 15:14
@svenklemm svenklemm requested review from mkindahl, nikkhils, mfundul and gayyappan and removed request for a team March 26, 2021 15:14
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #3064 (89c8bfa) into master (3c17802) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3064      +/-   ##
==========================================
+ Coverage   90.23%   90.26%   +0.02%     
==========================================
  Files         213      213              
  Lines       34835    34885      +50     
==========================================
+ Hits        31435    31488      +53     
+ Misses       3400     3397       -3     
Impacted Files Coverage Δ
src/constraint_aware_append.c 92.38% <100.00%> (ø)
src/planner.c 93.51% <100.00%> (-0.19%) ⬇️
src/copy.c 87.39% <0.00%> (-0.52%) ⬇️
tsl/src/fdw/modify_exec.c 82.63% <0.00%> (-0.50%) ⬇️
src/process_utility.c 93.85% <0.00%> (-0.05%) ⬇️
tsl/src/nodes/gapfill/exec.c 96.26% <0.00%> (+<0.01%) ⬆️
src/chunk_insert_state.c 97.67% <0.00%> (+0.01%) ⬆️
tsl/src/bgw_policy/job.c 97.34% <0.00%> (+0.01%) ⬆️
tsl/src/continuous_aggs/create.c 96.89% <0.00%> (+0.01%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c17802...89c8bfa. Read the comment docs.

The hypertable argument to ts_constraint_aware_append_path_create was
never actually used in the function so this patch removes it.
clang-format-8 was removed from the Ubuntu image so we have to
install it explicitly for the code formatting check.

actions/runner-images#2950
@svenklemm svenklemm merged commit 42b4566 into timescale:master Apr 1, 2021
@svenklemm svenklemm deleted the ca_ht branch April 18, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants