Make VACUUM tests more resilient #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
pmwkaa,
nikkhils and
k-rus
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #3085 +/- ##
==========================================
- Coverage 90.28% 90.25% -0.03%
==========================================
Files 213 213
Lines 34885 34885
==========================================
- Hits 31495 31486 -9
- Misses 3390 3399 +9
Continue to review full report at Codecov.
|
PG13 changes index vacuum behaviour in versions after 13.2 so index vacuum is no longer triggered when inserting only. This lead to test failures in the ABI test which was running PG13 snapshot but will also lead to test differences between 13.2 and 13.3 when that is released. This patch removes the indexes from the vacuum and vacuum multi tests and makes them smaller for vacuum_parallel test to make the size stable. postgres/postgres@9663d12
k-rus
approved these changes
Apr 3, 2021
gayyappan
approved these changes
Apr 5, 2021
pmwkaa
approved these changes
Apr 5, 2021
The reason vacuum and vacuum_multi was separate is because vacuuming multiple relations is only supported in PG11+. Since we no longer support versions < PG11 we can combine those 2 tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG13 changes index vacuum behaviour in versions after 13.2 so
index vacuum is no longer triggered when inserting only.
This lead to test failures in the ABI test which was running
PG13 snapshot but will also lead to test differences between
13.2 and 13.3 when that is released.
This patch removes the indexes from the vacuum and vacuum multi
tests and makes them smaller for vacuum_parallel test to make
the size stable.
postgres/postgres@9663d12
Fixes #3073
Disable-check: commit-count