Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command execution in pr-validation #3100

Merged
merged 1 commit into from Apr 12, 2021

Conversation

svenklemm
Copy link
Member

The github action to check for multiple commits would check the
pullrequest message for a command to disable the check.
While processing the message any commands enclosed in backticks
would be executed as shell commands.

@svenklemm svenklemm requested a review from a team as a code owner April 9, 2021 21:31
@svenklemm svenklemm requested review from pmwkaa, k-rus and gayyappan and removed request for a team April 9, 2021 21:31
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #3100 (4cd9e88) into master (31e1a9c) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3100      +/-   ##
==========================================
+ Coverage   90.20%   90.29%   +0.09%     
==========================================
  Files         215      215              
  Lines       35299    35249      -50     
==========================================
- Hits        31841    31829      -12     
+ Misses       3458     3420      -38     
Impacted Files Coverage Δ
src/loader/bgw_message_queue.c 84.51% <0.00%> (-2.59%) ⬇️
src/loader/bgw_launcher.c 89.50% <0.00%> (-2.47%) ⬇️
tsl/src/data_node_dispatch.c 97.07% <0.00%> (-0.25%) ⬇️
tsl/src/reorder.c 82.10% <0.00%> (+0.26%) ⬆️
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31e1a9c...4cd9e88. Read the comment docs.

The github action to check for multiple commits would check the
pullrequest message for a command to disable the check.
While processing the message any commands enclosed in backticks
would be executed as shell commands.
@svenklemm svenklemm merged commit 292574b into timescale:master Apr 12, 2021
@svenklemm svenklemm deleted the cmd_execution branch April 18, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants