Add GitHub action for posting daily CI summary #3126
Conversation
svenklemm
requested review from
pmwkaa,
mfundul and
gayyappan
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
==========================================
+ Coverage 90.24% 90.29% +0.05%
==========================================
Files 215 215
Lines 35360 35254 -106
==========================================
- Hits 31911 31834 -77
+ Misses 3449 3420 -29
Continue to review full report at Codecov.
|
.github/workflows/ci_summary.yaml
Outdated
| # run daily 8:00 CET on master branch | ||
| - cron: '0 7 * * *' | ||
| jobs: | ||
| build_summary: |
There was a problem hiding this comment.
If I am not mistaken, this will run on every fork of this repo, including our private one.
We've seen issues with this previously, where we have a lot of runs on the private repo that eats into our credits. We also don't want other forks to run this so should add some type of conditional:
https://github.community/t/do-not-run-cron-workflows-in-forks/17636
There was a problem hiding this comment.
We have cron jobs with the same setup, which runs every night and it doesn't run on forks. According to the documentation:
Scheduled workflows run on the latest commit on the default or base branch.
So I don't see an issue.
| @@ -0,0 +1,61 @@ | |||
| #!/usr/bin/python3 | |||
|
|
|||
| from datetime import datetime | |||
There was a problem hiding this comment.
Can we add basic unit tests for this code similar to what we have for the Git hooks: https://github.com/timescale/timescaledb/blob/master/scripts/githooks/commit_msg_tests.py
Otherwise, there's a lot of Python code to "just trust" here.
svenklemm
force-pushed
the
ci_summary
branch
2 times, most recently
from
02cb017
to
9f642ed
Compare
The patch removes the Slack notification of individual workflows in favor of the Slack summary message
This patch adds a GitHub action that posts all failed CI jobs in the last 24 hours with link to the failed job.
This patch adds a GitHub action that posts all failed CI jobs in
the last 24 hours with link to the failed job.
Disable-check: commit-count