Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused job_type from policies #3273

Merged
merged 1 commit into from May 26, 2021
Merged

Remove unused job_type from policies #3273

merged 1 commit into from May 26, 2021

Conversation

svenklemm
Copy link
Member

When refactoring the job code the job_type was removed from our
catalog but a few places got overlooked that still had a variable
holding the job type.

@svenklemm svenklemm requested a review from a team as a code owner May 24, 2021 23:26
@svenklemm svenklemm requested review from pmwkaa, afiskon, mfundul and gayyappan and removed request for a team May 24, 2021 23:26
@svenklemm svenklemm self-assigned this May 24, 2021
When refactoring the job code the job_type was removed from our
catalog but a few places got overlooked that still had a variable
holding the job type.
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3273 (c95e7fd) into master (77a3d5a) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   90.33%   90.46%   +0.12%     
==========================================
  Files         216      216              
  Lines       36036    35980      -56     
==========================================
- Hits        32553    32548       -5     
+ Misses       3483     3432      -51     
Impacted Files Coverage Δ
tsl/src/bgw_policy/compression_api.c 79.83% <ø> (-0.17%) ⬇️
tsl/src/bgw_policy/continuous_aggregate_api.c 93.61% <ø> (-0.03%) ⬇️
tsl/src/bgw_policy/job_api.c 97.41% <ø> (-0.02%) ⬇️
tsl/src/bgw_policy/reorder_api.c 94.56% <ø> (-0.06%) ⬇️
tsl/src/bgw_policy/retention_api.c 88.61% <ø> (-0.10%) ⬇️
tsl/src/continuous_aggs/job.c 0.00% <ø> (ø)
src/bgw/job.c 91.44% <100.00%> (ø)
src/import/planner.c 70.30% <0.00%> (+11.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77a3d5a...c95e7fd. Read the comment docs.

@svenklemm svenklemm merged commit c861efa into master May 26, 2021
@svenklemm svenklemm deleted the remove_job_type branch May 26, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants