Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky pg_dump test #3291

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix flaky pg_dump test #3291

merged 1 commit into from
Jun 2, 2021

Conversation

svenklemm
Copy link
Member

Stop background workers in test after calling timescaledb_post_restore
since this function restarts background workers.

@svenklemm svenklemm requested a review from a team as a code owner June 2, 2021 05:09
@svenklemm svenklemm requested review from afiskon, erimatnor and mfundul and removed request for a team June 2, 2021 05:09
@svenklemm svenklemm self-assigned this Jun 2, 2021
@svenklemm svenklemm requested a review from mkindahl June 2, 2021 05:12
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #3291 (042e794) into master (dd3e422) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3291      +/-   ##
==========================================
- Coverage   90.51%   90.51%   -0.01%     
==========================================
  Files         212      212              
  Lines       35494    35494              
==========================================
- Hits        32128    32127       -1     
- Misses       3366     3367       +1     
Impacted Files Coverage Δ
tsl/src/nodes/data_node_dispatch.c 97.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3e422...042e794. Read the comment docs.

@svenklemm svenklemm requested a review from gayyappan June 2, 2021 05:47
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/sql/pg_dump.sql Outdated Show resolved Hide resolved
Stop background workers in test after calling timescaledb_post_restore
since this function restarts background workers.
@svenklemm svenklemm merged commit 3b48d73 into master Jun 2, 2021
@svenklemm svenklemm deleted the pg_dump_fix branch June 24, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants