Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect TAP test prerequisites with CMake #3299

Merged
merged 1 commit into from Jun 5, 2021

Conversation

erimatnor
Copy link
Contributor

@erimatnor erimatnor commented Jun 3, 2021

CMake now detects if the necessary prerequisites for running TAP
tests are installed on the local system. This includes perl
installation and other dependencies, such as the IPC::Run module and
prove binary.

@erimatnor erimatnor self-assigned this Jun 3, 2021
@erimatnor erimatnor force-pushed the perl-check branch 4 times, most recently from c375e18 to ff6ed13 Compare June 3, 2021 13:51
@erimatnor erimatnor changed the title Detect TAP test pre-requisites with CMake Detect TAP test prerequisites with CMake Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #3299 (1ecf172) into master (3b48d73) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
- Coverage   90.50%   90.50%   -0.01%     
==========================================
  Files         212      212              
  Lines       35494    35494              
==========================================
- Hits        32124    32123       -1     
- Misses       3370     3371       +1     
Impacted Files Coverage Δ
src/compat.h 100.00% <ø> (ø)
src/event_trigger.c 96.32% <100.00%> (ø)
tsl/src/compression/compression.c 95.42% <100.00%> (ø)
tsl/src/nodes/gapfill/exec.c 97.00% <100.00%> (ø)
tsl/src/nodes/data_node_dispatch.c 97.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e339f...1ecf172. Read the comment docs.

@erimatnor erimatnor marked this pull request as ready for review June 3, 2021 14:27
@erimatnor erimatnor requested a review from a team as a code owner June 3, 2021 14:27
@erimatnor erimatnor requested review from pmwkaa, afiskon, nikkhils, mkindahl and a team and removed request for a team June 3, 2021 14:27
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@erimatnor erimatnor force-pushed the perl-check branch 3 times, most recently from 08bdeab to b6dad79 Compare June 4, 2021 07:06
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@erimatnor erimatnor requested a review from nikkhils June 4, 2021 09:41
CMake now detects if the necessary prerequisites for running TAP
tests are installed on the local system. This includes perl
installation and other dependencies, such as the IPC::Run module and
prove binary.
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erimatnor erimatnor merged commit 8e1273c into timescale:master Jun 5, 2021
@erimatnor erimatnor deleted the perl-check branch June 5, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants