Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make provecheck run specific tap tests #3311

Merged
merged 1 commit into from Jun 9, 2021

Conversation

nikkhils
Copy link
Contributor

@nikkhils nikkhils commented Jun 8, 2021

Introduce a shell wrapper around perl prove utility to control running
of TAP tests. The following control variable is supported:

PROVE_TESTS: only run TAP tests from this list

e.g make provecheck PROVE_TESTS="t/foo.pl t/bar.pl"

Note that you can also use regular expressions to run multiple taps
tests matching the pattern:

e.g make provecheck PROVE_TESTS="t/*chunk*"

If the existing "TESTS=" option is used along with PROVE_TESTS then
the subset represented by PROVE_TESTS will also get run. Otherwise tap
tests will be skipped if "TESTS=" is specified.

e.g make installcheck TESTS=dist_hyper* PROVE_TESTS="t/001_*"

@nikkhils nikkhils self-assigned this Jun 8, 2021
@nikkhils nikkhils requested a review from a team as a code owner June 8, 2021 13:49
@nikkhils nikkhils requested review from pmwkaa, afiskon and svenklemm and removed request for a team June 8, 2021 13:49
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #3311 (731c03d) into master (5719c50) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3311   +/-   ##
=======================================
  Coverage   90.51%   90.51%           
=======================================
  Files         212      212           
  Lines       35494    35495    +1     
=======================================
+ Hits        32128    32129    +1     
  Misses       3366     3366           
Impacted Files Coverage Δ
src/copy.c 90.40% <100.00%> (-0.04%) ⬇️
src/hypertable.c 87.99% <100.00%> (+0.02%) ⬆️
tsl/src/nodes/data_node_copy.c 95.58% <100.00%> (ø)
tsl/src/nodes/data_node_dispatch.c 97.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 264b77e...731c03d. Read the comment docs.

Copy link
Contributor

@erimatnor erimatnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question/nit.

test/pg_prove.sh Outdated Show resolved Hide resolved
test/pg_prove.sh Show resolved Hide resolved
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Introduce a shell wrapper around perl prove utility to control running
of TAP tests. The following control variable is supported:

PROVE_TESTS: only run TAP tests from this list

e.g make provecheck PROVE_TESTS="t/foo.pl t/bar.pl"

Note that you can also use regular expressions to run multiple taps
tests matching the pattern:

e.g make provecheck PROVE_TESTS="t/*chunk*"

If the existing "TESTS=" option is used along with PROVE_TESTS then
the subset represented by PROVE_TESTS will also get run. Otherwise tap
tests will be skipped if "TESTS=" is specified.

e.g make installcheck TESTS=dist_hyper* PROVE_TESTS="t/001_*"
@nikkhils nikkhils merged commit 093d021 into timescale:master Jun 9, 2021
@nikkhils nikkhils deleted the tap_enhance branch June 9, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants