Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error #3324

Merged
merged 1 commit into from Jun 11, 2021
Merged

Fix compile error #3324

merged 1 commit into from Jun 11, 2021

Conversation

mfundul
Copy link
Contributor

@mfundul mfundul commented Jun 11, 2021

Fix the following compile error:

tsl/src/remote/stmt_params.c: In function 'stmt_params_convert_values':
tsl/src/remote/stmt_params.c:246:3: error: 'nest_level' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  246 |   reset_transmission_modes(nest_level);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tsl/src/remote/stmt_params.c: At top level:
cc1: error: unrecognized command line option '-Wno-unused-command-line-argument' [-Werror]
cc1: all warnings being treated as errors
make[2]: *** [tsl/src/CMakeFiles/timescaledb-tsl.dir/build.make:1077: tsl/src/CMakeFiles/timescaledb-tsl.dir/remote/stmt_params.c.o] Error 1

Error: 'nest_level' may be used uninitialized in this function.
@mfundul mfundul requested review from a team, pmwkaa, afiskon and nikkhils and removed request for a team, pmwkaa, afiskon and nikkhils June 11, 2021 11:25
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #3324 (3a09b04) into master (318d2fd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3324      +/-   ##
==========================================
- Coverage   90.56%   90.55%   -0.01%     
==========================================
  Files         211      211              
  Lines       35475    35476       +1     
==========================================
  Hits        32127    32127              
- Misses       3348     3349       +1     
Impacted Files Coverage Δ
src/compat.h 100.00% <ø> (ø)
src/plan_expand_hypertable.c 94.02% <100.00%> (+0.01%) ⬆️
tsl/src/fdw/data_node_scan_plan.c 97.60% <100.00%> (-0.03%) ⬇️
tsl/src/fdw/scan_plan.c 93.98% <100.00%> (ø)
tsl/src/nodes/decompress_chunk/qual_pushdown.c 91.27% <100.00%> (+0.05%) ⬆️
tsl/src/nodes/skip_scan/planner.c 95.41% <100.00%> (ø)
tsl/src/remote/stmt_params.c 96.29% <100.00%> (+0.02%) ⬆️
tsl/src/nodes/data_node_dispatch.c 97.08% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5837a5...3a09b04. Read the comment docs.

@mfundul mfundul merged commit ed63a2a into timescale:master Jun 11, 2021
@mfundul mfundul deleted the fix-compile-error branch June 11, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants