New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updates to handle sequences #3339
Conversation
You don't. You only grant privileges for all future sequences in the update test. Not as part of the extension installation, which would be strange.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. You need to fix the commit message though so that it doesn't look like the extension sets default privileges for all installations. The change you have is only for the update test.
Ah yes, the commit message suggests that whole sale. Will change |
Codecov Report
@@ Coverage Diff @@
## master #3339 +/- ##
==========================================
- Coverage 90.58% 90.57% -0.02%
==========================================
Files 211 211
Lines 35536 35536
==========================================
- Hits 32192 32188 -4
- Misses 3344 3348 +4
Continue to review full report at Codecov.
|
The post-update script was handling preserving initprivs for newly added catalog tables and views. However, newly added catalog sequences need separate handling otherwise update tests start failing. We also now grant privileges for all future sequences in the update tests. In passing, default the PG_VERSION in the update tests to 12 since we don't work with PG11 anymore.
The post-update script was handling preserving initprivs for newly
added catalog tables and views. However, newly added catalog sequences
need separate handling otherwise update tests start failing. We also
now grant privileges for all future sequences in the update tests.
In passing, default the PG_VERSION in the update tests to 12 since we
don't work with PG11 anymore.