Move timestamp_limits and with_clause_parser test #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
requested review from
nikkhils,
mfundul and
gayyappan
and removed request for
a team
svenklemm
force-pushed
the
shared_test2
branch
4 times, most recently
from
9dfa3c3
to
f6c6119
Compare
gayyappan
reviewed
Jun 22, 2021
| @@ -6,6 +6,8 @@ SET client_min_messages TO ERROR; | |||
|
|
|||
| SET ROLE :ROLE_DEFAULT_PERM_USER; | |||
|
|
|||
| CREATE SCHEMA test; | |||
There was a problem hiding this comment.
timestamp_limits test uses this and on normal regresscheck we precreate that schema too
gayyappan
approved these changes
Jun 22, 2021
mfundul
approved these changes
Jun 23, 2021
Move the timestamp_limits and with_clause_parser test to regresscheck-shared since those tests don't need a private database incurring less overhead to run those tests. Also add missing ORDER BY clauses to some of the queries in timestamp_limits to make the output more stable.
Codecov Report
@@ Coverage Diff @@
## master #3346 +/- ##
==========================================
- Coverage 92.17% 90.58% -1.59%
==========================================
Files 110 212 +102
Lines 14177 35589 +21412
==========================================
+ Hits 13067 32240 +19173
- Misses 1110 3349 +2239
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the timestamp_limits and with_clause_parser test to
regresscheck-shared since those tests don't need a private
database incurring less overhead to run those tests.