Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initialize_func_info() #3348

Merged
merged 1 commit into from Jun 22, 2021
Merged

Conversation

afiskon
Copy link
Contributor

@afiskon afiskon commented Jun 21, 2021

Refactor initialize_func_info()

Replace unnecessary chain of ts_extension_schema_oid() ->
ts_extension_schema_name() -> get_namespace_oid() calls with
a single OID lookup.

@afiskon afiskon requested a review from a team as a code owner June 21, 2021 09:55
@afiskon afiskon self-assigned this Jun 21, 2021
@afiskon afiskon enabled auto-merge (rebase) June 21, 2021 09:57
@afiskon afiskon force-pushed the refactor_initialize_func_info branch from d6b1b53 to 75c85ae Compare June 21, 2021 12:53
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #3348 (49ca827) into master (001f5d9) will decrease coverage by 1.57%.
The diff coverage is 88.45%.

❗ Current head 49ca827 differs from pull request most recent head 5999af5. Consider uploading reports for the commit 5999af5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3348      +/-   ##
==========================================
- Coverage   92.17%   90.59%   -1.58%     
==========================================
  Files         110      212     +102     
  Lines       14177    35588   +21411     
==========================================
+ Hits        13067    32240   +19173     
- Misses       1110     3348    +2238     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk.h 100.00% <ø> (ø)
src/chunk_adaptive.c 92.57% <ø> (+2.78%) ⬆️
src/chunk_append/chunk_append.c 97.41% <ø> (+0.90%) ⬆️
src/chunk_append/exec.c 95.84% <ø> (+1.66%) ⬆️
src/chunk_append/explain.c 82.81% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (-2.27%) ⬇️
src/chunk_append/transform.c 96.66% <ø> (-3.34%) ⬇️
... and 282 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d868b...5999af5. Read the comment docs.

@afiskon afiskon force-pushed the refactor_initialize_func_info branch from 75c85ae to 49ca827 Compare June 21, 2021 13:44
@afiskon afiskon force-pushed the refactor_initialize_func_info branch from 49ca827 to 5999af5 Compare June 22, 2021 08:45
Replace unnecessary chain of ts_extension_schema_oid() ->
ts_extension_schema_name() -> get_namespace_oid() calls with
a single OID lookup.
@afiskon afiskon force-pushed the refactor_initialize_func_info branch from 5999af5 to a5a099e Compare June 22, 2021 09:15
@afiskon afiskon merged commit 9eec2a5 into master Jun 22, 2021
@afiskon afiskon deleted the refactor_initialize_func_info branch June 24, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants