Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export variables to docker-build #3369

Merged
merged 1 commit into from Jun 29, 2021

Conversation

mkindahl
Copy link
Contributor

This commit export the GENERATE_DOWNGRADE_SCRIPT and PG_VERSION
variables from test_downgrade_to_tag.sh to docker-build.sh.

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3369 (41eb0c2) into master (a3e8fd0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
+ Coverage   90.59%   90.60%   +0.01%     
==========================================
  Files         212      212              
  Lines       35620    35620              
==========================================
+ Hits        32271    32275       +4     
+ Misses       3349     3345       -4     
Impacted Files Coverage Δ
src/loader/bgw_message_queue.c 88.15% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e8fd0...41eb0c2. Read the comment docs.

@mkindahl mkindahl self-assigned this Jun 28, 2021
@mkindahl mkindahl marked this pull request as ready for review June 28, 2021 16:29
@mkindahl mkindahl requested a review from a team as a code owner June 28, 2021 16:29
@mkindahl mkindahl requested review from pmwkaa, afiskon, svenklemm and erimatnor and removed request for a team and afiskon June 28, 2021 16:29
Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkindahl mkindahl enabled auto-merge (rebase) June 29, 2021 07:28
This commit export the `GENERATE_DOWNGRADE_SCRIPT` and `PG_VERSION`
variables from `test_downgrade_to_tag.sh` to `docker-build.sh`.
@mkindahl mkindahl merged commit e28b9d0 into timescale:master Jun 29, 2021
@mkindahl mkindahl deleted the add_script_exports branch June 29, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants