Always define 'format' target #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
requested review from
afiskon,
nikkhils and
svenklemm
and removed request for
a team
mfundul
reviewed
Jun 28, 2021
mfundul
approved these changes
Jun 28, 2021
mkindahl
force-pushed
the
fix_format_target
branch
from
aeada5c
to
a770f97
Compare
mkindahl
force-pushed
the
fix_format_target
branch
from
a770f97
to
b669c44
Compare
afiskon
reviewed
Jun 28, 2021
If `clang-format` is not found `CLANG_FORMAT` will be set to a false value, which will prevent the `format` target from being defined if `cmake-format` is not installed. This commit fixes that by always creating a `format` target since `clang-format` is always created even if `CLANG_FORMAT` is false. We do not redefine `CLANG_FORMAT` to a non-false value since it is expected to contain a path to an executable and if set to a true value that is not a path it could be used in a way that leads to strange errors.
mkindahl
force-pushed
the
fix_format_target
branch
from
b669c44
to
f877fda
Compare
afiskon
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
clang-formatis not foundCLANG_FORMATwill be set to a falsevalue, which will prevent the
formattarget from being defined ifcmake-formatis not installed.This commit fixes that by always creating a
formattarget sinceclang-formatis always created even ifCLANG_FORMATis false.We do not redefine
CLANG_FORMATto a non-false value since it isexpected to contain a path to an executable and if set to a true value
that is not a path it could be used in a way that leads to strange
errors.