Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split update and downgrade version #3381

Merged
merged 1 commit into from Jul 1, 2021

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Jul 1, 2021

During an update, it is not possible to run the downgrade scripts until
the release has been tagged, but the update scripts can be run. This
means that we need to split the previous version into two different
fields: one for running the update tests and one for running the
downgrade tests.

@mkindahl mkindahl self-assigned this Jul 1, 2021
@mkindahl mkindahl marked this pull request as ready for review July 1, 2021 11:50
@mkindahl mkindahl requested a review from a team as a code owner July 1, 2021 11:50
@mkindahl mkindahl requested review from afiskon, svenklemm and mfundul and removed request for a team July 1, 2021 11:50
@mkindahl mkindahl enabled auto-merge (rebase) July 1, 2021 12:23
During an update, it is not possible to run the downgrade scripts until
the release has been tagged, but the update scripts can be run. This
means that we need to split the previous version into two different
fields: one for running the update tests and one for running the
downgrade tests.
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #3381 (24c1401) into master (001f5d9) will decrease coverage by 1.56%.
The diff coverage is 88.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3381      +/-   ##
==========================================
- Coverage   92.17%   90.60%   -1.57%     
==========================================
  Files         110      212     +102     
  Lines       14177    35628   +21451     
==========================================
+ Hits        13067    32281   +19214     
- Misses       1110     3347    +2237     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk.h 100.00% <ø> (ø)
src/chunk_adaptive.c 92.57% <ø> (+2.78%) ⬆️
src/chunk_append/chunk_append.c 97.41% <ø> (+0.90%) ⬆️
src/chunk_append/exec.c 95.84% <ø> (+1.66%) ⬆️
src/chunk_append/explain.c 82.81% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (-2.27%) ⬇️
src/chunk_append/transform.c 96.66% <ø> (-3.34%) ⬇️
... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7fffe...24c1401. Read the comment docs.

@NunoFilipeSantos NunoFilipeSantos requested review from erimatnor and removed request for mfundul July 1, 2021 13:37
@mkindahl mkindahl requested review from gayyappan and removed request for svenklemm July 1, 2021 13:37
@mkindahl mkindahl merged commit a58ebdb into timescale:master Jul 1, 2021
@mkindahl mkindahl deleted the split_versions branch July 1, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants