Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version modifier #3387

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix version modifier #3387

merged 1 commit into from
Jul 5, 2021

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Jul 5, 2021

The variable VERSION_MOD is used by config.h.

@mkindahl mkindahl self-assigned this Jul 5, 2021
@mkindahl mkindahl requested a review from a team as a code owner July 5, 2021 06:41
@mkindahl mkindahl requested review from pmwkaa, afiskon and nikkhils and removed request for a team July 5, 2021 06:41
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #3387 (fbb5984) into master (001f5d9) will decrease coverage by 1.55%.
The diff coverage is 88.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
- Coverage   92.17%   90.61%   -1.56%     
==========================================
  Files         110      212     +102     
  Lines       14177    35658   +21481     
==========================================
+ Hits        13067    32310   +19243     
- Misses       1110     3348    +2238     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk.h 100.00% <ø> (ø)
src/chunk_adaptive.c 92.57% <ø> (+2.78%) ⬆️
src/chunk_append/chunk_append.c 97.41% <ø> (+0.90%) ⬆️
src/chunk_append/exec.c 95.84% <ø> (+1.66%) ⬆️
src/chunk_append/explain.c 82.81% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (-2.27%) ⬇️
src/chunk_append/transform.c 96.66% <ø> (-3.34%) ⬇️
... and 279 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9946408...fbb5984. Read the comment docs.

Copy link
Contributor

@nikkhils nikkhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkindahl mkindahl enabled auto-merge (rebase) July 5, 2021 07:15
The variable `VERSION_MOD` is used by `config.h`.
@mkindahl mkindahl merged commit 0e505dd into timescale:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants