New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI against PG snapshots #3519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3519 +/- ##
==========================================
- Coverage 90.70% 90.69% -0.02%
==========================================
Files 212 212
Lines 36278 36278
==========================================
- Hits 32906 32902 -4
- Misses 3372 3376 +4
Continue to review full report at Codecov.
|
@@ -66,7 +66,11 @@ jobs: | |||
- name: Build PostgreSQL ${{ matrix.pg }} ${{ matrix.build_type }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be Build PostgreSQL ${{ matrix.pg }} ${{matrix.snapshot}} ${{ matrix.build_type }}
?
And more importantly, shouldn't the cache above it include the snapshot
otherwise it will conflict on the same key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key won't conflict since matrix.pg is either 12 or 13 for snapshots while it's exact version for non-snapshots e.g. 13.4
But i should probably disable cache entirely for snapshots.
7f7e252
to
f77977a
Compare
Run CI against PG snapshots to discover potential issues with upcoming PG releases earlier.
Run CI against PG snapshots to discover potential issues with
upcoming PG releases earlier.