Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against PG snapshots #3519

Merged
merged 1 commit into from Aug 30, 2021
Merged

Conversation

svenklemm
Copy link
Member

Run CI against PG snapshots to discover potential issues with
upcoming PG releases earlier.

@svenklemm svenklemm requested a review from a team as a code owner August 25, 2021 16:05
@svenklemm svenklemm requested review from erimatnor, mkindahl, nikkhils, gayyappan and mfundul and removed request for a team August 25, 2021 16:05
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #3519 (d01a9a1) into master (f7eceba) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3519      +/-   ##
==========================================
- Coverage   90.70%   90.69%   -0.02%     
==========================================
  Files         212      212              
  Lines       36278    36278              
==========================================
- Hits        32906    32902       -4     
- Misses       3372     3376       +4     
Impacted Files Coverage Δ
src/adts/bit_array_impl.h 97.27% <ø> (ø)
src/bgw/job.c 91.63% <ø> (ø)
src/bgw/launcher_interface.c 72.22% <ø> (ø)
src/bgw/scheduler.c 83.04% <ø> (ø)
src/bgw/timer.c 66.66% <ø> (ø)
src/bgw_policy/chunk_stats.c 80.00% <ø> (ø)
src/cache.c 89.78% <ø> (ø)
src/cache_invalidate.c 85.41% <ø> (ø)
src/catalog.c 84.61% <ø> (ø)
src/chunk.c 96.12% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe9cb4...d01a9a1. Read the comment docs.

@@ -66,7 +66,11 @@ jobs:
- name: Build PostgreSQL ${{ matrix.pg }} ${{ matrix.build_type }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be Build PostgreSQL ${{ matrix.pg }} ${{matrix.snapshot}} ${{ matrix.build_type }}?

And more importantly, shouldn't the cache above it include the snapshot otherwise it will conflict on the same key?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The key won't conflict since matrix.pg is either 12 or 13 for snapshots while it's exact version for non-snapshots e.g. 13.4
But i should probably disable cache entirely for snapshots.

@svenklemm svenklemm force-pushed the ci_snapshot branch 6 times, most recently from 7f7e252 to f77977a Compare August 30, 2021 16:59
Run CI against PG snapshots to discover potential issues with
upcoming PG releases earlier.
@svenklemm svenklemm merged commit 2ee30f9 into timescale:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants